docs: deployment reality — webhook coverage, router bypass flags, v1 limitations
Co-Authored-By: Claude Fable 5 <[email protected]>
This commit is contained in:
co-authored by
Claude Fable 5
parent
7d7b69e4e4
commit
9f2927c33e
@@ -68,10 +68,24 @@ Bot identity: Gitea user `shre-reviewer` (created via `gitea admin user create`)
|
|||||||
|
|
||||||
## Deploy (Mac dev tier)
|
## Deploy (Mac dev tier)
|
||||||
|
|
||||||
- `launchd/ai.granthi.review.plist` → `~/Library/LaunchAgents/`, KeepAlive service on :5498.
|
- `launchd/ai.granthi.review.plist` → `~/Library/LaunchAgents/`, KeepAlive service on :5498, running from the `~/Services/granthi-review` clone.
|
||||||
- `launchd/ai.granthi.review.digest.plist` → nightly 03:30 `--digest` run.
|
- `launchd/ai.granthi.review.digest.plist` → nightly 03:30 `--digest` run.
|
||||||
- Webhooks: Gitea **system webhook** (admin → hooks) pointed at `http://host.docker.internal:5498/webhook` (the gitea container reaches the host that way), events push + pull_request, secret = `webhookSecret`. Fallback: per-repo hooks on pilot repos.
|
- Webhooks (all target `http://host.docker.internal:5498/webhook`, events push + pull_request, secret = `webhookSecret`):
|
||||||
- Pilot gating: `nirpa/gitea-distro` main branch protection lists `granthi-review` in `status_check_contexts` (alongside the CI build context); `enable_approvals_whitelist`/admin-bypass left so admins can merge over a block.
|
- **Per-repo hooks** on the pilot repos: `nirpa/gitea-distro`, `nirpa/granthi-staging-infra`, `nirpa/granthi-review`.
|
||||||
|
- **Admin default hook** (`POST /api/v1/admin/hooks`) — Gitea 1.27's API can only create *default* hooks (copied into repos created after the hook exists), not *system* hooks, so every **new** repo is auto-wired but pre-existing repos need a per-repo hook. To cover the whole estate in one shot, create the same hook as a **system webhook** via the admin web UI (Site Administration → Integrations → Webhooks → System Webhooks) — API tokens cannot do it in 1.27.
|
||||||
|
- Pilot gating: `nirpa/gitea-distro` main branch protection lists `granthi-review` in `status_check_contexts` (alongside `build-branded-image / build`); `block_admin_merge_override` is false, so admins can merge over a block (the override path).
|
||||||
|
|
||||||
|
### Router integration notes (learned live)
|
||||||
|
|
||||||
|
- The shre-router request MUST carry `tools:false` and `raw:true`, otherwise keyword fast-paths (current-info briefing, store-resolver, retail dispatch) hijack review prompts whose diff content mentions github/sales/store-ish words and return non-review text.
|
||||||
|
- The domain preflight can 400 (`agent_mismatch`) when the intent classifier misreads a diff; attempt 2 retries as the c-suite `fallbackAgentId` (default `architect`), which bypasses the tier-gated preflight.
|
||||||
|
- The router may serve a different model than requested (`_shre.model` is recorded in the ledger's `model` column).
|
||||||
|
|
||||||
|
### Known v1 limitations
|
||||||
|
|
||||||
|
- The review queue is in-memory: a service restart drops queued/in-flight reviews, leaving that sha's `granthi-review` status at `pending`. Re-push (or push an empty commit) to re-trigger.
|
||||||
|
- Bare pushes get status + ledger only (no Gitea commit-comment API).
|
||||||
|
- Reviews for repos outside the pilot set require the bot (`shre-reviewer`) to have write access before statuses/comments can post; grant collaborator write when adding repos.
|
||||||
|
|
||||||
## Adding the Reviews tab later (Granthi overlay)
|
## Adding the Reviews tab later (Granthi overlay)
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user