fix: raw:true bypass for router keyword fast-paths + c-suite fallback agent

Two live-observed router hijack modes on diff content: (1) retail/store
fast-paths (store-resolver, arm:sales) intercepting prompts whose diffs
mention sales/store-ish words, (2) domain preflight 400 agent_mismatch
when the intent classifier confidently misclassifies a diff. raw:true
(_bypassToolRouting) disables the keyword intercepts; attempt 2 retries
as the configurable c-suite fallback agent (architect) which bypasses
the tier-gated domain preflight.

Co-Authored-By: Claude Fable 5 <[email protected]>
This commit is contained in:
Nirav Patel
2026-08-19 00:00:37 -04:00
co-authored by Claude Fable 5
parent 7416df88c9
commit f7b56297a8
3 changed files with 15 additions and 5 deletions
+2
View File
@@ -11,6 +11,8 @@ const DEFAULTS = {
webhookSecret: '', webhookSecret: '',
routerUrl: 'http://localhost:5497', routerUrl: 'http://localhost:5497',
model: 'anthropic/claude-sonnet-4-6', model: 'anthropic/claude-sonnet-4-6',
agentId: 'code-reviewer',
fallbackAgentId: 'architect',
tenantId: 'nirlab', tenantId: 'nirlab',
publicBaseUrl: 'http://localhost:5498', publicBaseUrl: 'http://localhost:5498',
dbPath: join(CONFIG_DIR, 'reviews.db'), dbPath: join(CONFIG_DIR, 'reviews.db'),
+5 -1
View File
@@ -71,9 +71,13 @@ export async function runReview({ cfg, gitea, db, job, withGlobal, log }) {
await withGlobal(async () => { await withGlobal(async () => {
for (let attempt = 1; attempt <= 2; attempt++) { for (let attempt = 1; attempt <= 2; attempt++) {
try { try {
// Attempt 1 uses the review agent. Attempt 2 falls back to the
// c-suite agent (bypasses the router's domain preflight), covering
// classifier false-positives on diff content: agent_mismatch 400s
// and tool fast-path hijacks that return non-JSON.
const out = await chat({ const out = await chat({
routerUrl: cfg.routerUrl, model: cfg.model, messages, routerUrl: cfg.routerUrl, model: cfg.model, messages,
agentId: 'code-reviewer', agentId: attempt === 1 ? cfg.agentId : cfg.fallbackAgentId,
sessionId: `review-${owner}-${repo}-${sha.slice(0, 12)}-a${attempt}`, sessionId: `review-${owner}-${repo}-${sha.slice(0, 12)}-a${attempt}`,
tenantId: cfg.tenantId, timeoutMs: cfg.routerTimeoutMs tenantId: cfg.tenantId, timeoutMs: cfg.routerTimeoutMs
}); });
+8 -4
View File
@@ -6,10 +6,14 @@ export async function chat({ routerUrl, model, messages, agentId, sessionId, ten
const res = await fetch(`${routerUrl.replace(/\/$/, '')}/v1/chat`, { const res = await fetch(`${routerUrl.replace(/\/$/, '')}/v1/chat`, {
method: 'POST', method: 'POST',
headers: { 'Content-Type': 'application/json' }, headers: { 'Content-Type': 'application/json' },
// tools:false — reviews need pure model reasoning; it also keeps the // tools:false + raw:true — reviews need pure model reasoning. raw:true is
// router's tool/skill fast-paths (e.g. current-info briefing) from // the router's sanctioned _bypassToolRouting flag: without it, keyword
// hijacking prompts whose diffs mention GitHub/news-like terms. // fast-paths (current-info briefing, store-resolver, retail dispatch)
body: JSON.stringify({ model, messages, agentId, sessionId, tenantId, stream: false, tools: false }), // hijack prompts whose DIFF CONTENT mentions github/sales/store-ish terms
// and return non-review text. The domain preflight (agent_mismatch 400)
// still applies per agent tier; the pipeline's attempt-2 fallback agent
// covers that.
body: JSON.stringify({ model, messages, agentId, sessionId, tenantId, stream: false, tools: false, raw: true }),
signal: AbortSignal.timeout(timeoutMs) signal: AbortSignal.timeout(timeoutMs)
}); });
if (!res.ok) { if (!res.ok) {